TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
`MC_PLAYER_GET_ACTIVE_MAX_CHARGE` should provide the maxCharge arg
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
Currently provides the idx, playerEntity and varData, it would be handy if it also provided the max amount of charges the item should have so we could decrease it, currently possible to do with itemConfig, but it would be nice if maxCharges were a part of the maxCharge callback aswell.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the C++ implementation of MC_PLAYER_GET_ACTIVE_MAX_CHARGE and trace the callback's Lua-facing argument list. Compare its existing idx, playerEntity, and varData handling with itemConfig, then verify that the callback exposes the requested maximum charge value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- api, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100