TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
LevelGenerator bug?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
static LinkDirection ComputeAdjustedLinkDirection(LevelGenerator_Room const& source, int index) in LuaLevelGenerator.cpp is not working as far as I know. I've tried placing several larger room shapes with the LevelGenerator:PlaceRoom lua function and they always fail with an invalid adjusted link direction. This of course does not occur with simple 1x1 room shapes.
The code has two if statements on lines 265 and 271 that do the exact same check (perhaps this a starting point as to where the error is coming from):
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in repentogon/LuaInterfaces/LuaLevelGenerator.cpp at ComputeAdjustedLinkDirection, especially the checks around lines 265 and 271. Reproduce the issue by placing larger room shapes through LevelGenerator:PlaceRoom, then trace how the adjusted link direction is computed. Done means larger room shapes no longer fail with an invalid adjusted link direction, while simple 1x1 rooms continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100