TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

`MC_POST_FIRE_X` and `MC_POST_FAMILIAR_FIRE_X` functions should have a `owner` param

Open
#458 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

callback request enhancement
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

It would be way easier to use these callbacks if they also provided the entity that fired the mentioned tear / bomb / etc...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the implementations and bindings for MC_POST_FIRE_X and MC_POST_FAMILIAR_FIRE_X, then trace how their callback arguments are assembled. Confirm the owner entity is available for each event and update the callback interface so both expose it; done means callers receive the firing entity for tears, bombs, and similar projectiles.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.