TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
ModCallbacks.MC_GET_SHOP_ITEM_PRICE overwrite issue
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
If you try to force, lets say, only red heart deals in ModCallbacks.MC_GET_SHOP_ITEM_PRICE the game can still overwrite them when the player doesn't currently have any red hearts with soul heart deals.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ModCallbacks.MC_GET_SHOP_ITEM_PRICE entry point and reproduce the red-heart-only case when the player has no red hearts. Trace where the game replaces the callback's result with soul-heart deals, then verify that the requested red-heart deal remains unchanged in that situation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100