TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Sprite related methods in CharacterMenu does not respect modded characters.

Open
#377 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

Certain methods in CharacterMenu does not respect modded characters with some of their sprite getter methods like GetCharacterPortraitSprite. This is likely because modded characters have their own unique sprite.

This could be fixed by modifying the menu to have vanilla and modded characters share the same sprite, or an easier (Yet messier for modders) solution would to just add a separate getter method for characters.

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at CharacterMenu and inspect the sprite getter methods, including GetCharacterPortraitSprite, to determine how vanilla and modded characters are selected. Confirm the intended sprite behavior for modded characters and verify that the affected methods return the appropriate sprites without breaking vanilla characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.