TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
ModCallbacks.MC_PRE_RENDER_CUSTOM_CHARACTER_MENU has a unusable sprite argument
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
This callback only triggers for custom characters, yet the sprite argument only triggers on vanilla characters, which means that it's basically useless, so I propose a replacement for the sprite argument.
Replace that argument with DefaultSprite (PlayerConfig:GetModdedMenuBackgroundSprite()) and add another argument for PortraitSprite (PlayerConfig:GetModdedMenuPortraitSprite()), two new arguments that would be really useful to have in there.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ModCallbacks.MC_PRE_RENDER_CUSTOM_CHARACTER_MENU and the PlayerConfig methods GetModdedMenuBackgroundSprite() and GetModdedMenuPortraitSprite(). Verify how the callback currently receives its sprite argument, then confirm the callback exposes the requested DefaultSprite and PortraitSprite values for custom characters.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100