TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Callback that runs when the players health is updated

Open
#311 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

callback request
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

Something like MC_PLAYER_HEALTH_UPDATE.
While we have post damage callbacks, there’s a lot of other ways the players health can change. If we wanted to make a feature which did something when the players health changes, while not impossible and likely just needing to be ran/checked every frame, this would make it a heck of a lot easier/nicer, as it would be less code running every frame.
Ideally this would fire not just when the player gains/loses health, but also whenever they get a health up, health down, broken heart, full heart reroll, etc — basically, anything that changes the players hp.
This would have no return parameters as it is merely for checking the values, not changing them.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing post-damage callback implementation and tracing the player-health changes described in the issue, including health ups, health downs, broken hearts, and full-heart rerolls. Done means a callback fires for each relevant health change, exposes no return parameters, and avoids requiring a per-frame check.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
api, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.