TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

[suggestion/bug] main_ex.lua interferes with past versions of other mods (i honestly don't know how) ?

Open
#295 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

i made a mod that regroups other small mods (https://steamcommunity.com/sharedfiles/filedetails/?id=3033761471&searchtext=the+sussy+moai), and recently pruned it of two lua using mods that do not work anymore. Somehow, main_ex.lua (the repentogon file in isaac/resources/scripts) redefined the "require" function in such a way that it thinks that my mod's main.lua still calls upon the deleted mod's lua, through the deleted line "require(character_specific_items)", thereby causing an error mesage to appear in the console upon run start.
please keep in mind that i'm in no way an expert in coding and may have done a horrible lapse in my judgment.
(side note, i really love repentogon. good job)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with isaac/resources/scripts/main_ex.lua and inspect how its redefined require function resolves Lua modules. Reproduce the reported startup error using the described mod setup, including the deleted require(character_specific_items) line in main.lua. Done means an old or removed module reference no longer produces the reported console error.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.