TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
[Request] Fix the PushRenderTarget log spam
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
Dear Repentogon Devs,
Could you fix this bug in the game? It is described here, under StartRoomTransition (): https://wofsauge.github.io/IsaacDocs/rep/Game.html
Transcription of the bug description:
Note that if you use RoomTransitionAnim.PIXELATION (2), you must not interrupt the effect (e.g. with another room transition or room change) once it starts playing. Otherwise, after around 11 interuptions, the "log.txt" will start to become spammed with "[ASSERT] - PushRenderTarget: stack overflow!". This is because internally, the game uses a finite buffer to store information about the effect, and if it is interrupted, the buffer will never be cleared.
Game Version: 1.7.9b
Repentogon Version: 1.0.4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the StartRoomTransition() behavior described in the linked IsaacDocs page, then trace the PushRenderTarget assertion and its handling in the repository. Reproduce repeated interrupted PIXELATION transitions and verify that the log no longer accumulates stack-overflow messages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev, reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100