TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
EntityConfigPlayer:GetAchievementID doesn't work with modded characters
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
Testing with the Community Remix mod. The Adam character has the following set in players.xml:
achievement="Adam"
Isaac.GetAchievementIdByName('Adam') returns 638
EntityConfig.GetPlayer(41):GetAchievementID() returns 0 rather than 638. 41 is Adam for me.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Community Remix case using the players.xml achievement="Adam" entry, then compare Isaac.GetAchievementIdByName('Adam') with EntityConfig.GetPlayer(41):GetAchievementID(). Trace the EntityConfigPlayer:GetAchievementID entry point and verify that it returns the same achievement ID for modded characters rather than 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- devtools, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100