TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
[ZHL] Improve logger
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
Right now the ZHL::Logger opens a file every time it is created instead of using a buffer that gets flushed regularly. This can lead to performance issues. Improve this by either using a buffer or opening the file once at the start of the game and closing it at the end (this may lead to logs getting lost if the game crashes).
There is also a strong possibility that KAGE::LogMessage has a similar issue, which is bad and quite hard to fix.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ZHL::Logger and KAGE::LogMessage in the C++ source and tracing when their files are opened, written, flushed, and closed. Compare a buffered design with opening the file once for the game lifecycle, then verify that logging remains correct and that both logger paths are addressed or their scope is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- observability
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100