TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
MC_POST_PLAYER_GET_MULTI_SHOT_PARAMS does not provide params as an arg.
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
The only way to construct or get multishot params is by running the GetMultiShotParams method under the player class, which results in an overflow / loop, as the callback fires after retrieving params to overwrite itself with.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing MC_POST_PLAYER_GET_MULTI_SHOT_PARAMS through the player class and its GetMultiShotParams method. Confirm how the callback retrieves and overwrites the parameters, then define completion as exposing the multishot parameters directly to the callback without the resulting overflow or loop.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100