TeamNewPipe / TeamNewPipe/NewPipeExtractor

[Refactor][Nice to have] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler

Open
#80 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2k
Forks
602
Avg merge
3d 6h
Merged PRs (30d)
6

Description

Its quit confusing if you want to implement a service getTimeStamp is in the context of the StreamExtractor and not the upload date or something like this. It would be better to move this to the StreamUrlIdHandler because its a url parsing part and not something that is in the meta data of the stream, like the most data that is can be accessed over the StreamExtractor

++ extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamUrlIdHandler.java

public interface StreamUrlIdHandler extends UrlIdHandler {
String getTimeStamp(String url) throws ParsingException;
}

or directly in the living standard implementation of url parsing that comes with DTube and MediaCCC support. (Url Parsing get maybe moved to a whole new project)

Relevent for new implementations.
And currently in the DTube Implementation (already fixed local):
Wrong Implementation
|_ Usage of Wrong Implementation
|_ Base Needs to be removed
|_ Base Needs to be removed now

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review StreamExtractor.java and StreamUrlIdHandler.java to determine where getTimeStamp belongs, then inspect the referenced DTubeStreamExtractor.java and DTubeParsingHelper.java usages. Compare the rename and relocation options before choosing a consistent API boundary. Done means the timestamp responsibility and naming are consistent across the affected interfaces and DTube implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.