TeamNewPipe / TeamNewPipe/NewPipeExtractor
Inconsistent 'empty' return values
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 602
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 6
Description
NewPipeExtractor has inconsistent return values in some places for when there is e.g. no HLS URL, i.e:
media.ccc.de
@Nonnull
@Override
public String getHlsUrl() throws ParsingException {
return null;
}
PeerTube
@Override
public String getHlsUrl() throws ParsingException {
return "";
}
SoundCloud
@Nonnull
@Override
public String getHlsUrl() throws ParsingException {
return "";
}
HLS URLs aren't the only case where that happens.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the getHlsUrl implementations in the media.ccc.de, PeerTube, and SoundCloud extractors, then inspect other extractor methods with similar empty-value behavior. Establish a consistent convention for absent values and apply it across the affected cases; done means the inconsistent null and empty-string returns are resolved consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100