TeamNewPipe / TeamNewPipe/NewPipeExtractor
Always return whatever YouTube provides when filtering search
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 602
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 6
Description
This snippet comes from YouTube search extractor's collectStreamsFrom. At the moment we are using these boolean values to only return the requested type of items (e.g. channels) even if YouTube provides some other unrequested item types (e.g. the channel's videos).
In my opinion the extractor should be transparent to such inconsistencies, and just return whatever YouTube provides. Basically, in my opinion b71ce1123f5e3a99f3e4287d10565c0489c840df should be reverted. What do you think @FireMasterK @AudricV?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeSearchExtractor.java at collectStreamsFrom, and compare the filtering logic with commit b71ce1123f5e3a99f3e4287d10565c0489c840df. Done means YouTube search results return every item type provided by YouTube, including types not requested by the caller.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, search
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100