TeamAmaze / TeamAmaze/AmazeFileManager

Broken SaveExternalIntent to SMB

Open
#4,395 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Sharing Area-SMB Issue-Bug
Dominant language
Kotlin
Stars
6.4k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
1

Description

Describe the bug
When selecting Amaze's "Save as" in the sharing context menu of other apps it does not handel a save location on a SMB at all.
The debug shows that the code-path creates file-paths like "/smb:/IP/Folder" where IP is numerical and correct, likewise the Folder is also valid.
Looking at the code it seems that a save location on an SMB is not considered at all, to the point of this being close to a feature request.

To Reproduce
Steps to reproduce the behavior:

  1. Go into your gallery-app of choice
  2. Select one or multiple Pictures
  3. Share them
  4. Select Amaze's "Save as" in the context menu
  5. Select an SMB-Folder as the save location
  6. Observe the popup saying it will copy with the correct and non-mangled path no less - though that is because it is using the original var
  7. Wait for it to do nothing further as the operation already crashed and the text is only shown because some try:catch is doing its job
  8. Look in the ADB Log and search for "/smb:/" to find the error trace

Expected behavior
The files passed by the external intent should be save to the SMB-Folder selected within Amaze.

Smartphone (please complete the following information):

  • Device: Sony (something idk)
  • OS: Android 15
  • Rooted: No
  • Version: 3.10 (FDroid & Playstore Release) & Debug Build of the current 4.0 Release Branch

Additional context
SMB is a rare feature for File-Manager apps - especially Non-Paid and Ad-Free ones.
I am happy that the normal Copy/Paste works fine from and to an SMB-Folder.
But since not everyone is familiar with browsing through Androids folder structure they rather use Apps which are more suitable to browse, for example, pictures.
It would be nice if SMB were to become feature complete in Amaze.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace SaveExternalIntent from the external sharing flow and inspect the ADB error containing /smb:/. Reproduce with an SMB folder and compare the selected destination with the path used by the copy operation. Done means files shared through another app are saved to the selected SMB folder without the /smb:/ path failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.