TeamAmaze / TeamAmaze/AmazeFileManager
Check whether an SMB Connection exists when adding; fail otherwise
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 6.4k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
Describe the bug
I tried to create an SMB Connection offline, which should have failed, but it works currently.
To Reproduce
Steps to reproduce the behavior:
- Enter the app
- Open "Airplane mode" (to be offline without network)
- "+"
- Cloud Connection
- SMB Connection
- USE CUSTOM IP
- Enter any IP, Username, Password (e.g., a, a, a)
- CREATE -> [The app hints error first time]
- UPDATE -> [The button change from CREATE to UPDATE, and could be update successfully]
- Repeat Step 3-8 -> [The app hints that connection already exists]
Expected behavior
The connection should be checked instead of directly succeeding and saving, e.g., invalid IP or not network should be rejected.
Screenshots
https://github.com/user-attachments/assets/266570c1-5193-4e26-8023-1d0f90d93676
Smartphone (please complete the following information):
- Device: Pixel 8
- OS: Android 14
- Rooted: No
- Version: 3.10
Additional context
I reproduced the above problem with a reinstall of the app.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the Android app using Airplane mode, then follow the Cloud Connection > SMB Connection > USE CUSTOM IP flow through CREATE and UPDATE. Trace where the SMB connection is validated and saved, and confirm that offline or invalid connections are rejected before they are stored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100