TeamAmaze / TeamAmaze/AmazeFileManager
'SMB Connection' dialog shows with an error message, but the connection is successfully established after canceling
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 6.4k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
Describe the Bug
- The loading spinner appears for a while.
- The 'SMB Connection' dialog then displays with an error message: "Oops, something went wrong!"
- However, after dismissing the dialog by clicking the 'CANCEL' button, the SMB connection is still created successfully, as seen by clicking the hamburger icon.
Steps to Reproduce
Click the '+' icon.
Click the 'Cloud Connection' button.
Select 'SMB Connection'.
Click 'USE CUSTOM IP'.
Enter a server IP address in the 'Server IP Address' text field (e.g., 'test.com').
Click the 'CREATE' button.
When the 'SMB Connection' dialog appears with an error message, click 'CANCEL'.
Open the hamburger menu to check the connection status.
Expected Behavior
- It should not display an error message if the connection is successful.
- If the connection fails, the SMB connection should not be created after clicking 'CANCEL'.
- The loading spinner should display for an appropriate duration, and the success or failure of the connection should be accurately reflected.
Screen Recording
https://github.com/user-attachments/assets/7d72dffa-6bc3-4dd9-aa3a-059fd7d8d83b
Smartphone (please complete the following information):
- Device: Google Pixel 5
- OS: Android 14
- Rooted: No
- Version: 3.10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the flow on Android 14 using version 3.10: open Cloud Connection, select SMB Connection, use a custom IP, and create the connection. Trace the SMB connection creation and the error dialog's CANCEL handling. Done means successful connections do not show an error, while failed connections are not retained after cancellation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100