TeamAmaze / TeamAmaze/AmazeFileManager

NPE on `MainActivity#saveExternalIntentExtras`

Open
#4,074 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Crash-NullPointerException From-Email Issue-Easy (good first issue)
Dominant language
Kotlin
Stars
6.4k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
1

Description

Issue explanation (write below this line)

Exception

  • App Name: Amaze File Manager
  • Package: com.amaze.filemanager
  • Version: 3.8.4
  • User Action: UI Error
  • Request: Application crash
  • OS: Linux samsung/a54xnsxx/a54x:14/UP1A.231005.007/A546EXXU5BWL1:user/release-keys 14 - 34
  • Device: a54x
  • Model: SM-A546E
  • Product: a54xnsxx
Crash log 

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.os.Bundle.getString(java.lang.String)' on a null object reference
at com.amaze.filemanager.ui.activities.MainActivity.lambda$saveExternalIntentExtras$5(MainActivity.java:686)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$UZ7Fb6FhBq7Cp6GS1zremCHYIto(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda25.apply(Unknown Source:4)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2506)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2498)
at com.amaze.filemanager.ui.activities.MainActivity.saveExternalIntentExtras(MainActivity.java:682)
at com.amaze.filemanager.ui.activities.MainActivity.lambda$saveExternalIntent$3(MainActivity.java:667)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$kS-j1GWs8fVOlm6tVzii9t3P9TM(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda16.apply(Unknown Source:6)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2506)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2498)
at com.amaze.filemanager.ui.activities.MainActivity.saveExternalIntent(MainActivity.java:646)
at com.amaze.filemanager.ui.activities.MainActivity.lambda$initFabToSave$2(MainActivity.java:642)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$Gd_V2QQE8wk6UL2HKEkN_ex5VMI(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda11.run(Unknown Source:4)
at com.amaze.filemanager.utils.Utils.lambda$showThemedSnackbar$0(Utils.java:324)
at com.amaze.filemanager.utils.Utils.$r8$lambda$Nq4P65Npwao55dZx17kNIJZ2UpI(Unknown Source:0)
at com.amaze.filemanager.utils.Utils$$ExternalSyntheticLambda0.onClick(Unknown Source:2)
at com.google.android.material.snackbar.Snackbar$1.onClick(Snackbar.java:351)
at android.view.View.performClick(View.java:8043)
at android.widget.TextView.performClick(TextView.java:17816)
at android.view.View.performClickInternal(View.java:8020)
at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
at android.view.View$PerformClick.run(View.java:31850)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:8893)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Issue explanation (write below this line)

Exception

  • App Name: Amaze File Manager
  • Package: com.amaze.filemanager
  • Version: 3.8.4
  • User Action: UI Error
  • Request: Application crash
  • OS: Linux samsung/a54xnsxx/a54x:14/UP1A.231005.007/A546EXXU5BWL1:user/release-keys 14 - 34
  • Device: a54x
  • Model: SM-A546E
  • Product: a54xnsxx
Crash log 

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.os.Bundle.getString(java.lang.String)' on a null object reference
at com.amaze.filemanager.ui.activities.MainActivity.lambda$saveExternalIntentExtras$5(MainActivity.java:686)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$UZ7Fb6FhBq7Cp6GS1zremCHYIto(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda25.apply(Unknown Source:4)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2506)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2498)
at com.amaze.filemanager.ui.activities.MainActivity.saveExternalIntentExtras(MainActivity.java:682)
at com.amaze.filemanager.ui.activities.MainActivity.lambda$saveExternalIntent$3(MainActivity.java:667)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$kS-j1GWs8fVOlm6tVzii9t3P9TM(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda16.apply(Unknown Source:6)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2506)
at com.amaze.filemanager.ui.activities.MainActivity.executeWithMainFragment(MainActivity.java:2498)
at com.amaze.filemanager.ui.activities.MainActivity.saveExternalIntent(MainActivity.java:646)
at com.amaze.filemanager.ui.activities.MainActivity.lambda$initFabToSave$2(MainActivity.java:642)
at com.amaze.filemanager.ui.activities.MainActivity.$r8$lambda$Gd_V2QQE8wk6UL2HKEkN_ex5VMI(Unknown Source:0)
at com.amaze.filemanager.ui.activities.MainActivity$$ExternalSyntheticLambda11.run(Unknown Source:4)
at com.amaze.filemanager.utils.Utils.lambda$showThemedSnackbar$0(Utils.java:324)
at com.amaze.filemanager.utils.Utils.$r8$lambda$Nq4P65Npwao55dZx17kNIJZ2UpI(Unknown Source:0)
at com.amaze.filemanager.utils.Utils$$ExternalSyntheticLambda0.onClick(Unknown Source:2)
at com.google.android.material.snackbar.Snackbar$1.onClick(Snackbar.java:351)
at android.view.View.performClick(View.java:8043)
at android.widget.TextView.performClick(TextView.java:17816)
at android.view.View.performClickInternal(View.java:8020)
at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
at android.view.View$PerformClick.run(View.java:31850)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:8893)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Sent from Proton Mail mobile

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in MainActivity.java at saveExternalIntentExtras around lines 682-686, where the crash log reports a null Bundle during the save UI flow. Run the save action that reaches this method and verify the flow no longer throws a NullPointerException when the Bundle is absent.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.