TeamAmaze / TeamAmaze/AmazeFileManager

Call remote command directly if both source and target files are on the same FTP/SSH server

Open
#3,637 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area-FTPClient Area-Ssh/Scp/Sftp Issue-Feature
Dominant language
Kotlin
Stars
6.4k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
1

Description

Is your feature request related to a problem? Please describe.
When both source and target files are on the same FTP/SSH server, we should make use of remote commands to copy/move files solely on the server, without ever touching the client side, to improve copy/move efficiency

Describe the solution you'd like
GenericCopyUtils.copy() may add a shortcut routine so that, when source and target URIs are FTP/SSH URIs and both are on the same host, call cp or mv on the remote directly

Describe alternatives you've considered
N/A

Additional context
Depends on #1347 - we should have better handling, parsing, less error-prone and less complicated implementation of NetCopyClientConnectionPool.ConnectionInfo before talking about this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the prerequisite in #1347 and the handling of NetCopyClientConnectionPool.ConnectionInfo, then inspect GenericCopyUtils.copy(). Define how FTP/SSH source and target URIs identify the same host. Done means same-host copies or moves use remote cp or mv without transferring data through the client.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile, networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.