TeamAmaze / TeamAmaze/AmazeFileManager
Unable to show reauthenticate smb dialog after instance state change
Open
Nobody has claimed this yet.
From-Email
Issue-Task (low)
- Dominant language
- Kotlin
- Stars
- 6.4k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
Issue explanation (write below this line)
Exception
- App Name: Amaze Dateimanager
- Package: com.amaze.filemanager
- Version: 3.6.7
- User Action: UI Error
- Request: Application crash
- OS: Linux Android 6.0.1 - 23
- Device: trlte
- Model: SM-N910F
- Product: trltexx
Crash log
java.lang.IllegalStateException: Can not perform this action after
onSaveInstanceState
at android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1428)
at android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1446)
at android.app.BackStackRecord.commitInternal(BackStackRecord.java:687)
at android.app.BackStackRecord.commit(BackStackRecord.java:663)
at android.app.DialogFragment.show(DialogFragment.java:230)
at
com.amaze.filemanager.ui.activities.MainActivity.showSMBDialog(MainActivity.java:1908)
at
com.amaze.filemanager.ui.fragments.MainFragment.lambda$reauthenticateSmb$12(MainFragment.java:1148)
at
com.amaze.filemanager.ui.fragments.MainFragment.lambda$reauthenticateSmb$12$MainFragment(MainFragment.java)
at
com.amaze.filemanager.ui.fragments.-$$Lambda$MainFragment$T1C_ZKCvIEGpVIwCPu0TIr_12Po.run(lambda)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:158)
at android.app.ActivityThread.main(ActivityThread.java:7225)
at java.lang.reflect.Method.invoke(Native Method)
at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MainActivity.java around showSMBDialog at line 1908 and MainFragment.java around reauthenticateSmb at line 1148. Trace the dialog request through the Android activity lifecycle and reproduce the state-change path. Done means reauthentication no longer crashes after onSaveInstanceState and the SMB dialog can be shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100