TeamAmaze / TeamAmaze/AmazeFileManager
NPE when trying to initialize empty areas for drag and drop
Open
Nobody has claimed this yet.
Area-UIUX
Crash-Intermittent
Crash-NullPointerException
From-telegram
- Dominant language
- Kotlin
- Stars
- 6.4k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
Issue explanation (write below this line)
Exception
- App Name: Amaze File Manager
- Package: com.amaze.filemanager
- Version: 3.6.7
- User Action: UI Error
- Request: Application crash
- OS: Linux Android 11 - 30
- Device: laurel_sprout
- Model: Mi A3
- Product: havoc_laurel_sprout
Crash log
java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter adapter
at com.amaze.filemanager.ui.drag.RecyclerAdapterDragListener.<init>(Unknown Source:2)
at com.amaze.filemanager.ui.fragments.MainFragment.initTopAndEmptyAreaDragListeners(MainFragment.java:1586)
at com.amaze.filemanager.ui.fragments.TabFragment.initLeftRightAndTopDragListeners(TabFragment.java:455)
at com.amaze.filemanager.ui.activities.MainActivity.initLeftRightAndTopDragListeners(MainActivity.java:2256)
at com.amaze.filemanager.ui.activities.MainActivity.initCornersDragListener(MainActivity.java:2231)
at com.amaze.filemanager.adapters.RecyclerAdapter.initDragListener(RecyclerAdapter.java:1105)
at com.amaze.filemanager.adapters.RecyclerAdapter.lambda$onBindViewHolder$1(RecyclerAdapter.java:718)
at com.amaze.filemanager.adapters.RecyclerAdapter.lambda$onBindViewHolder$1$RecyclerAdapter(Unknown Source:0)
at com.amaze.filemanager.adapters.-$$Lambda$RecyclerAdapter$Y1p0JWIN4qQXhFWAhju3PXWBx8M.onLongClick(Unknown Source:11)
at android.view.View.performLongClickInternal(View.java:7535)
at android.view.View.performLongClick(View.java:7493)
at android.view.View.performLongClick(View.java:7511)
at android.view.View$CheckForLongPress.run(View.java:28271)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Reporter: Shivam_hobbyist
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at RecyclerAdapter.initDragListener and follow the calls into MainActivity.initCornersDragListener, TabFragment.initLeftRightAndTopDragListeners, and MainFragment.initTopAndEmptyAreaDragListeners. Reproduce the long-click drag-and-drop action on Android 11 and inspect the RecyclerAdapterDragListener constructor shown in the crash. Done means initializing empty areas for drag and drop no longer crashes with a null adapter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java, kotlin
- Domain
- frontend, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100