TeamAmaze / TeamAmaze/AmazeFileManager

StringIndexOutOfBoundsException on access of Google Drive

Open
#2,695 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Cloud From-Email Issue-Bug
Dominant language
Kotlin
Stars
6.4k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
1

Description

Issue explanation (write below this line)

Crashed 1st use
This after it would not load contents of Google drive directory and then I
tried to past local folder into that folder.

Exception

  • App Name: Amaze File Manager
  • Package: com.amaze.filemanager
  • Version: 3.6.1
  • User Action: UI Error
  • Request: Application crash
  • OS: Linux
    xiaomi/jasmine/jasmine_sprout:10/QKQ1.190910.002/V11.0.27.0.QDIMIXM:user/release-keys
    10 - 29
  • Device: jasmine_sprout
  • Model: Mi A2
  • Product: jasmine
Crash log

java.lang.StringIndexOutOfBoundsException: length=8; index=13
at java.lang.String.substring(String.java:2027)
at
com.amaze.filemanager.filesystem.files.FileUtils.splitUri(FileUtils.java:652)
at
com.amaze.filemanager.filesystem.files.FileUtils.getPathsInPath(FileUtils.java:605)
at
com.amaze.filemanager.ui.views.appbar.BottomBar.showButtons(BottomBar.java:238)
at
com.amaze.filemanager.ui.views.appbar.BottomBar.updatePath(BottomBar.java:559)
at
com.amaze.filemanager.ui.fragments.TabFragment.updateBottomBar(TabFragment.java:437)
at
com.amaze.filemanager.ui.fragments.TabFragment.updatepaths(TabFragment.java:207)
at
com.amaze.filemanager.ui.activities.MainActivity.updatePaths(MainActivity.java:1382)
at
com.amaze.filemanager.ui.fragments.MainFragment.reloadListElements(MainFragment.java:1089)
at
com.amaze.filemanager.ui.fragments.MainFragment.setListElements(MainFragment.java:996)
at
com.amaze.filemanager.ui.fragments.MainFragment.lambda$loadlist$3(MainFragment.java:945)
at
com.amaze.filemanager.ui.fragments.MainFragment.lambda$loadlist$3$MainFragment(Unknown
Source:0)
at
com.amaze.filemanager.ui.fragments.-$$Lambda$MainFragment$9qQv21X8JwPlLXi_cDXfu4p-_VI.onAsyncTaskFinished(Unknown
Source:8)
at
com.amaze.filemanager.asynchronous.asynctasks.LoadFilesListTask.onPostExecute(LoadFilesListTask.java:278)
at
com.amaze.filemanager.asynchronous.asynctasks.LoadFilesListTask.onPostExecute(LoadFilesListTask.java:68)
at android.os.AsyncTask.finish(AsyncTask.java:755)
at android.os.AsyncTask.access$900(AsyncTask.java:192)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:772)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7403)
at java.lang.reflect.Method.invoke(Native Method)
at
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)


Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at FileUtils.splitUri(FileUtils.java:652), called from getPathsInPath(FileUtils.java:605), using the reported Google Drive directory and pasted local folder flow as the reproduction. Trace how the URI is parsed before BottomBar.showButtons is reached. Done means that this access path no longer throws StringIndexOutOfBoundsException and the directory contents can be handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.