TeamAmaze / TeamAmaze/AmazeFileManager

Fix saving the state for Settings Activity

Open
#2,475 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-CodeHealth Issue-Bug
Dominant language
Kotlin
Stars
6.4k
Forks
1.7k
Avg merge
3d 9h
Merged PRs (30d)
1

Description

Currently the activity for the settings contains android:configChanges="orientation|screenSize":

https://github.com/TeamAmaze/AmazeFileManager/blob/06028eda9a5384f529a66c2ed314a43fa9e70006/app/src/main/AndroidManifest.xml#L119-L130

Which fixes issues with rotation, but creates issues when the activity is destroyed and recreated, like selecting "Do not keep Activities" in dev settings and going to settings, going to another app then returning to Amaze.

The line android:configChanges="orientation|screenSize" should be removed and all resulting glitches/bugs fixes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Settings Activity entry in app/src/main/AndroidManifest.xml at the linked lines and reproduce the reported cases: rotation, “Do not keep Activities,” and returning from another app. Trace how the activity is recreated and identify the resulting state glitches. Done means removing android:configChanges="orientation|screenSize" while preserving settings state and avoiding the reported bugs.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.