TeamAmaze / TeamAmaze/AmazeFileManager
SMB connection dialog, anonymous connections can be saved without checking the anonymous checkbox
Open
Nobody has claimed this yet.
Area-SMB
Area-UIUX
Issue-Bug
- Dominant language
- Kotlin
- Stars
- 6.4k
- Forks
- 1.7k
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
Without entering username and/or password, user can still create/update a SMB connection to a public share. This makes the anonymous checkbox meaningless.
UI should
- block user from saving if username is not entered and anonymous checkbox is not checked
- disable username and password textfields if anonymous checkbox is checked
- allow save/update only when username is entered or anonymous checkbox is checked
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SMB connection dialog and reading its save and update entry points. Trace how the anonymous checkbox and username/password fields currently affect validation and enabled state. Done means saves are blocked without a username or checked anonymous option, and the credential fields are disabled when anonymous is selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- frontend, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100