TanStack / TanStack/virtual

Blank select listbox when re-opening in Firefox.

Open
#892 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
466
Avg merge
2d 31m
Merged PRs (30d)
13

Description

Describe the bug

If we reopen our Select listbox after scrolling down past the overscan value, the listbox has no options rendered. They appear in the DOM but not in the listbox. If you scroll even by 1px once reopened, the options render (I have attached a screen recording of this further down).

Your minimal, reproducible example

https://stackblitz.com/edit/parsium-carbon-starter-zza8bg?file=src%2FApp.tsx

Steps to reproduce
  1. Open Firefox and navigate to our Select virtualised example or the reproducible Stackblitz example

  2. Click the Select's component textbox to open it and scroll down beyond option 30 (the overscan value is 20, so a whole new list of options is rendered there)

  3. Close the listbox. This can be done by clicking away from the listbox.

  4. Click the Select's component textbox to reopen Select's listbox.

Actual Result:

Listbox is initially blank.

Expected Result:

Options to be visible.

Expected behavior

I expect there to be options in the listbox.

How often does this bug happen?

Every time

Screenshots or Videos

Firefox:
https://github.com/user-attachments/assets/6c2022b4-d56e-4bb0-925a-fbcfeb211839

Chrome:
https://github.com/user-attachments/assets/ed5d48c0-289c-42af-a84a-cc96de273fcb

Firefox but I scroll a small amount when reopening:
https://github.com/user-attachments/assets/6d7ba0f6-6540-4ac7-bb2a-3cc1ce763759

Platform

Operating Systems:

  • MacOS
  • Windows

Web Browser:

  • Firefox (I am using v133.0)
tanstack-virtual version

v3.10.1

TypeScript version

v4.7.0

Additional context

I was able to fix this bug using the code below. However, I was not prepared to merge it into our codebase as I don't think browser sniffing is a particularly good fix for this. Without the conditional check for Firefox, this would break our implementation on Chrome, Safari and Edge.

This is what seemed to fix it:

const SCROLL_OPTIONS: ScrollToOptions = { behavior: "auto", align: "end" };

const browserIsFirefox =
      navigator.userAgent.toLowerCase().indexOf("firefox") > -1;

    useEffect(() => {
      if (browserIsFirefox && isOpen && currentOptionsListIndex === -1) {
        virtualizer.scrollBy(0, SCROLL_OPTIONS);
      }
    });
Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproducible example in src/App.tsx and run the Select virtualised example in Firefox. Reproduce the failure by scrolling beyond the overscan value, closing the listbox, and reopening it, then compare the behavior with Chrome. Done means the options are visible immediately on reopening without requiring a scroll.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.