Not support responsive size?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.1k
- Forks
- 466
- Avg merge
- 2d 31m
- Merged PRs (30d)
- 13
Description
Describe the bug
I use useVirtualize with useWindowSize for the responsive item size.
const { width } = useWindowSize();
const columnVirtualizer = useVirtualizer({
horizontal: true,
count: 100,
getScrollElement: () => parentRef.current,
estimateSize: () => width / 10,
overscan: 5,
})
Even though the width is changed, columnVirtualizer doesn`t rerendered.
There is the code about the Virtualizer instance in useVirtualizerBase (/pacakges/react-virtual/src/index.tsx, line:39)
const [instance] = React.useState(
() => new Virtualizer<TScrollElement, TItemElement>(resolvedOptions),
)
Even if resolvedOptions have changed, initializing the instance only once.
Is this intentional?
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/rough-tdd-4wfpkr
Steps to reproduce
Refer to codesand box
Expected behavior
When I resize the window, items should rerender with new size
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
macOS
tanstack-virtual version
latest
TypeScript version
5.2.2
Additional context
No response
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior in the linked CodeSandbox, then inspect packages/react-virtual/src/index.tsx around useVirtualizerBase and the Virtualizer instance initialization at line 39. Trace how changing useWindowSize affects estimateSize and determine what behavior is expected when the window width changes. Done means the horizontal items rerender with the new responsive size.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100