TanStack / TanStack/virtual

Request Fullscreen Issue in Desktop Safari

Open
#639 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
466
Avg merge
2d 31m
Merged PRs (30d)
13

Description

Describe the bug

I am rendering a long list of content using useWindowVirtualizer.
Each list can be shown in full screen mode by clicking a button using domElement.requestFullscreen().
When I scroll down and request fullscreen on an item that is not rendered initially, the full screen pops up and closes immediately.
I assume this happens because the virtualizer thinks we just scrolled to the top as soon as the full screen is shown, then unmounts the element that we are displaying in full screen (because it's not visible when the list is scrolled to the top) which then closes the full screen again.
See codesandbox for an example. It works in Chrome, but fails in Safari.

Your minimal, reproducible example

https://c9l4ym-5173.csb.app

Steps to reproduce

Open the code sandbox on desktop safari in a new tab, scroll down and click request full screen.

Expected behavior

The element should be shown in full screen.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Desktop Safari

tanstack-virtual version

3.0.1

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the linked CodeSandbox on desktop Safari, using useWindowVirtualizer with an off-screen item and domElement.requestFullscreen(). Trace whether entering fullscreen causes the virtualizer to reset scrolling and unmount the fullscreen element; done means the off-screen item remains mounted and stays fullscreen in Safari without breaking the existing Chrome behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.