TanStack / TanStack/virtual

Angular Runtime NG0600: Writing to signals is not allowed introduced by (1085)

Open
#1,096 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.1k
Forks
466
Avg merge
2d 31m
Merged PRs (30d)
13

Description

Describe the bug

PR 1085 (4.0.1) has introduced the following issue in angular-virtual which is breaking normal behavior:

RuntimeError: NG0600: Writing to signals is not allowed in a computed or an effect by default. Use allowSignalWrites in the CreateEffectOptions to enable this inside effects.

Broadly speaking computed values derived from angular-tanstack signals are now in error since the notify change causes the virtualizer signal to be set. Evaluating the signal values probably should not have this side effect.

eg top of stack sets the virtualizer signal, bottom is a dervied value

**onChange                                           tanstack-angula...irtual.mjs:111**
**Virtualizer.notify                                 index.js:267**
**onChange                                           index.js:414**
memoizedFunction                                   utils.js:42
**Virtualizer.getMeasurements:memo.count.count       index.js:419**
memoizedFunction                                   utils.js:9
**Virtualizer.calculateRange:memo.range.measurements.length.calculateRange.meas...**
                                                   index.js:504
memoizedFunction                                   utils.js:9
**Virtualizer.getVirtualIndexes.rangeExtractor.startIndex.startIndex**
                                                   index.js:526
memoizedFunction                                   utils.js:9
**Virtualizer.getVirtualItems:virtualItems           index.js:618**
memoizedFunction                                   utils.js:9
(anonymous)                                        tanstack-angula...irtual.mjs:38
producerRecomputeValue                             signal.mjs:468
producerUpdateValueVersion                         signal.mjs:558
**computed2                                          signal.mjs:408**
(anonymous)                                        tanstack-

You can see this error in the console of the live example, though in this case it's originating from an effect (and in recent angular version setting signal inside an effect is legal).

Infinite scroll angular example

Your minimal, reproducible example

https://tanstack.com/virtual/latest/docs/framework/angular/examples/infinite-scroll

Steps to reproduce

Load example, examine console

Expected behavior

Error should not be thrown

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

Angular implementations

tanstack-virtual version

4.0.1

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the error in the linked Angular infinite-scroll example and inspect the stack entries in tanstack-angular-virtual.mjs and index.js. Compare the behavior introduced by PR 1085, focusing on the notify and computed-value path shown in the trace. Done means the example no longer throws NG0600 during normal signal evaluation.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.