TanStack / TanStack/router

Server Side Rendered HTML Response should return HTTP 200 when loader rejects

Open
#6,796 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.1k
Forks
1.9k
Avg merge
1d 20h
Merged PRs (30d)
143

Description

Which project does this relate to?

Start

Describe the bug

When loader rejects the server side rendered response returns HTTP 500 even though the HTML was successfully rendered.

I would expect it to be 200 because html was successfully server side rendered and returned.
http 500 is more for server failure and rejections of loaders are expected, it is not internal server error.

Your Example Website or App

https://github.com/valerii15298/tss-repros/tree/error-component-override

Steps to Reproduce the Bug or Issue

Start the app
Open Browser network devtools
Go to http://localhost:3000
See that response for html content returns 500

Expected behavior

Should return 200

Screenshots or Videos

https://discord.com/channels/719702312431386674/1477778007018963014/1477791443463573748

Platform
  • Router / Start Version: 1.165.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the linked error-component-override example using Router / Start 1.165.0, then inspect the server-side-rendered response handling. Confirm the behavior in the browser network tools and consider the issue done when a successfully rendered HTML response returns HTTP 200 even when a loader rejects.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.