TanStack / TanStack/query

useSyncExternalStore should have a correct/frozen getServerSnapshot

Open
#4,690 1 comment 1 reaction 1 assignee View on GitHub

@Ephem is already working on this.

Since May 22, 2023.

package: react-query v5
Dominant language
TypeScript
Stars
50.3k
Forks
4.2k
Avg merge
18h 25m
Merged PRs (30d)
200

Description

I think we should also do this in v5

@Ephem

sandbox that shows potential mismatch:

https://codesandbox.io/p/sandbox/epic-wind-bwwhes?file=%2Fapp%2Fpage.tsx&selection=%5B%7B%22endColumn%22%3A6%2C%22endLineNumber%22%3A1%2C%22startColumn%22%3A6%2C%22startLineNumber%22%3A1%7D%5D

from

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.