ignoreInput isn't detected across realms
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 719
- Forks
- 47
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 1
Description
The logic seen in https://github.com/TanStack/hotkeys/blob/6adcc3a1b0a28350eb421f6aeebcf0f94d177817/packages/hotkeys/src/manager.utils.ts#L48
will fail cross realms, the classes are only correct for the active realm. The check should use tagName instead for cross realm accesses.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/hotkeys/src/manager.utils.ts at line 48, where ignoreInput detection is implemented, and review how the current class-based check behaves across realms. Update the detection to use tagName, then verify that inputs from another realm are correctly ignored without breaking same-realm behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100