TIGER-AI-Lab / TIGER-AI-Lab/EditReward

Does the reward_dim parameter actually do anything?

Open
#24 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
160
Forks
6
PR merge metrics
No merged PRs in 30d

Description

I’ve noticed that whether I set it to dim1, dim2, or overall_detail, the output values remain exactly the same.
my code

import torch
from EditReward import EditRewardInferencer

CHECKPOINT_PATH = "EditReward-MiMo-VL-7B-SFT-2508"
CONFIG_PATH = "EditReward/config/EditReward-MiMo-VL-7B-SFT-2508.yaml"

_inferencer = None


def _get_inferencer(dim):
    global _inferencer
    if _inferencer is None:
        _inferencer = EditRewardInferencer(
            config_path=CONFIG_PATH,
            checkpoint_path=CHECKPOINT_PATH,
            device="cuda" if torch.cuda.is_available() else "cpu",
            reward_dim=dim,
        )
    return _inferencer


def compute_editreward_score(src_path: str, tgt_path: str, instruction: str, dim) -> float:
    inferencer = _get_inferencer(dim)
    with torch.no_grad():
        rewards = inferencer.reward(
            prompts=[instruction],
            image_src=[src_path],
            image_paths=[tgt_path]
        )
    print(rewards)
    print(dim)
    return rewards[0][0].item()


if __name__ == "__main__":
    img_src = "22_source.png"
    img_tgt = "22.png"
    prompt = "在古董车打开的行李箱里添加一只坐着的小棕狗。"
    score = compute_editreward_score(img_src, img_tgt, prompt, dim="dim1")
    print(f"EditReward result: {score:.4f}")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report through EditRewardInferencer and its reward entry point using the supplied script, testing dim1, dim2, and overall_detail with the same inputs. Then inspect EditReward/config/EditReward-MiMo-VL-7B-SFT-2508.yaml and the inferencer initialization to determine whether reward_dim is consumed; done when its behavior is explained and the issue is resolved or documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.