THUDM / THUDM/slime

Question on examples/search-r1/format_score

Open
#705 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.5k
Forks
1.3k
Avg merge
5h 36m
Merged PRs (30d)
22

Description

Hello! I found that in qa_em_format.py (examples/search-r1), format_score is defined in the parameter of function compute_score_em but isn't used in its implementation; maybe it's a redundant paremeter?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in examples/search-r1/qa_em_format.py and inspect the compute_score_em definition, focusing on whether its format_score parameter is used in the implementation. Done means confirming whether the parameter is redundant and resolving that inconsistency in the function definition.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.