THUDM / THUDM/slime

[Question] about --spec in model.sh

Open
#1,766 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Python
Stars
8.5k
Forks
1.3k
Avg merge
5h 36m
Merged PRs (30d)
22

Description

Your Question

I am wondering if --spec will work for megatron bridge?
For example, there is the {--spec "slime_plugins.models.qwen3_5" "get_qwen3_5_spec"} in scripts/models/qwen3.5-35B-A3B.sh. But I couldn't find where --spec should take effect in the Megatron Bridge. In the Megatron Bridge, qwen35_vl_provider.py calls block_spec = get_gpt_decoder_block_spec, not the externally passed --spec. Furthermore, I added some print statements in the get_qwen3_5_spec method, but these print statements had no effect when using the Megatron Bridge. So, do I understand that --spec doesn't work in the Megatron Bridge context?

What I've Tried

no

Environment (if relevant)
  • slime version:
  • Python version:
  • PyTorch version:
  • CUDA/ROCm version:
  • GPU type and count:
  • OS:
Additional Context

No response

Pre-submission Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with scripts/models/qwen3.5-35B-A3B.sh and trace how --spec is passed into the Megatron Bridge. Compare that path with qwen35_vl_provider.py, especially its call to get_gpt_decoder_block_spec. Done means clarifying whether the external spec is used in this context and documenting the observed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, shell
Domain
cli, machine-learning
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.