TEN-framework / TEN-framework/ten-framework
Do not use AddonManager::findAppBaseDir() from the Node.js binding
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 11.1k
- Forks
- 1.4k
- Avg merge
- 2d 15m
- Merged PRs (30d)
- 22
Description
Because it cannot handle symbolic links properly. Instead, switch to using the method from the C runtime to find the app base directory, since the C implementation can handle symbolic links. However, this requires the Node.js addon loader to also be able to run in scenarios where the app itself is a Node.js app. (#882)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the Node.js addon loader and the C runtime method used to find the app base directory. Check how the loader behaves when symbolic links are involved and when the app itself is a Node.js app; done means both scenarios use the C runtime behavior without breaking addon loading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, node.js
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100