TASEmulators / TASEmulators/BizHawk
Make `XmlGame.Create` parse through the whole file before reading roms' contents into memory
Open
Nobody has claimed this yet.
App: EmuHawk
Request: Feature/Enhancement
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
i.e. BindArchiveMember and even GetStream, but don't ReadAllBytes until after the main foreach ends
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at XmlGame.Create and trace the main foreach, including BindArchiveMember and GetStream. Confirm how ReadAllBytes currently loads ROM contents, then change the flow so the whole file is parsed before those contents are read into memory. Done means ReadAllBytes occurs only after the main foreach ends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100