TASEmulators / TASEmulators/BizHawk

"how is TAStudio open with no game loaded? please report this including as much detail as possible"

Open
#4,573 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

App: EmuHawk Repro: Affects 2.11
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Summary

System.InvalidOperationException: how is TAStudio open with no game loaded? please report this including as much detail as possible

Reporting as it asked me to (and the error gave me a chuckle), will probably work around it with Bizhawk 2.4 and copying inputs.

Repro
  1. Open BizHawk 2.11
  2. Load Sonic The Hedgehog 2 (EB) (V1.0) [!].sms (doesn't seem to matter if SMSHawk or GPGX).
  3. Open TAStudio
  4. Open Challenger's bk2 UserFile from Bizhawk 2.4: https://tasvideos.org/UserFiles/Info/638693521322570251
  5. Accept the Conversion to tasproj dialog
Image
  1. Click ok. ROM and TAStudio will close.
  2. Error; See Output
Output
System.InvalidOperationException: how is TAStudio open with no game loaded? please report this including as much detail as possible
   at BizHawk.Client.EmuHawk.TAStudio.StartNewTasMovie() in /src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs:line 586
   at BizHawk.Client.EmuHawk.TAStudio.LoadFileWithFallback(String path) in /src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs:line 685
   at BizHawk.Client.EmuHawk.TAStudio.LoadMovieFile(String filename, Boolean askToSave) in /src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs:line 98
   at BizHawk.Client.EmuHawk.TAStudio.OpenTasMenuItem_Click(Object sender, EventArgs e) in /src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs:line 84
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Host env.
  • BizHawk 2.11; Win11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs at StartNewTasMovie and LoadFileWithFallback, then review TAStudio.MenuItems.cs around LoadMovieFile and OpenTasMenuItem_Click. Reproduce with BizHawk 2.11, the Sonic The Hedgehog 2 ROM, and UserFile 638693521322570251. Done means the converted movie opens without closing the ROM or TAStudio and without throwing this exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.