TASEmulators / TASEmulators/BizHawk
Lua scripts: "active" status should interact better with registered functions
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
The basic idea is:
- A script that has registered functions should still be marked as "active" with the green checkmark
- Perhaps a script where the last registered function is later unregistered should change to inactive?
- Toggling the script to inactive unregisters any callbacks that the script registered
This is only a design proposal, but it would make the interface more consistent and the behavior clearer in my opinion.
It would also solve the issue where unloading/reloading a script creates more and more registered functions; this is not a large issue though, because Script > Registered Functions... can be used to remove registered functions.
Related: #4499
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading related issue #4499 and the existing Script > Registered Functions... workflow described here. The payload names no files or tests, so first establish the intended active-state and callback-unregistration rules; done requires an agreed design for both behaviors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100