TASEmulators / TASEmulators/BizHawk

Greenzone Validation Fails

Open
#4,366 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

re: Waterbox Repro: Affects 2.10 Repro: Affects 2.10.1 dev Tool: TAStudio
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Summary

It looks like waterbox (?) is not properly handling loading the initial save state from frame 0. At least two games for NDS (Mario Kart DS, New Super Mario Bros.), as well as at least one game (DK Country 3) in all SNES waterbox cores fail greenzone integrity check in TAStudio within the first few frames. All except Faust reliably fail at frame 1.

I'm not certain it is a waterbox issue, but my understanding is that waterbox is supposed to make this impossible. I also do not know if this issue can cause movie desyncs.

I have found this issue exists on the 2.10 release tag as well.

Repro
  1. Using default config
  2. Open Mario Kart DS (US)
  3. Open TAStudio
  4. Advance one frame
  5. Edit -> Savestate History Integrity Check
Host env.
  • Current master branch, Windows 11
  • BizHawk 2.10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with the default configuration using Mario Kart DS, TAStudio, and Edit → Savestate History Integrity Check after advancing one frame. Start by tracing the Savestate History Integrity Check and the waterbox initial-save handling; done means the first-frame greenzone integrity check passes for the reported NDS and SNES cases without introducing movie desyncs.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
testing-qa, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.