TASEmulators / TASEmulators/BizHawk
Reconcile duplicate gamedb entries
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Currently, hash collisions are still detected, but the warnings are no longer printed to stdout since fdb5dfb7e580645d76e2921a4653027a8fdcf4e6.
https://github.com/TASEmulators/BizHawk/blob/dc67699b9ede63dfe80239eaea5670cdec33a3a2/src/BizHawk.Emulation.Common/Database/Database.cs#L184-L187
(Note that this can't detect a SHA1 checksum which shadows an MD5 checksum. No idea what we can do about that except to burn the DB down and start again.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/BizHawk.Emulation.Common/Database/Database.cs around lines 184-187 and compare the behavior introduced by commit fdb5dfb7e580645d76e2921a4653027a8fdcf4e6. Reproduce the duplicate-entry or hash-collision case and determine the expected warning output. Done means duplicate gamedb entries are reconciled and the relevant collision warnings are again observable without attempting to address SHA1/MD5 shadowing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100