TASEmulators / TASEmulators/BizHawk
Verify downloaded binaries
A pull request for this has already been merged.
- #4287 by @YoshiRulz — merged
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
As of https://github.com/TASEmulators/BizHawk/commit/e0974e3c3092bd5f0027983ef863a7909f9c8d2f, the checksums for the FFmpeg binaries in the ffmpeg-binaries repo are hardcoded in FFmpegService. That will be checked before FFmpeg is ever executed.
As of the same commit, the RAIntegration download no longer blindly follows any address, it has to resolve to retroachievements.org.
RA's API seems to be down at the moment so I can't check if that includes a checksum, but even if it did, it would need to be signed as well (and we hardcode the pubkey).
Though as CPP points out below, the downloader isn't available out-of-the-box, so we don't have to worry about the endpoint coming back online and pushing broken (or malicious) updates.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with FFmpegService and the RAIntegration download path, using commit e0974e3c3092bd5f0027983ef863a7909f9c8d2f as context. Review the merged pull request 4287 and the hardcoded FFmpeg checksums, RA endpoint restriction, and signing requirements. Done means downloaded binaries are verified before use, with the existing security constraints preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100