TASEmulators / TASEmulators/BizHawk
Z80 debugger doesn't work with Genesis Plus GX.
Open
Nobody has claimed this yet.
Core: Genplus-gx
help wanted
Request: Feature/Enhancement
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Loaded core: Genesis Plus GX. (Master System mode)
ROM: SHA1:9ec22b866c3df95bcef6a422aec4e5fbe396750f Baku Baku (Brazil)
Open Tools: Attempted to open debugger for this core.
Repro
- Open ROM
- Open the debugger
- Error Message
Output
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at BizHawk.Client.EmuHawk.GenericDebugger.UpdateCapabilitiesProps() in /_/src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs:line 56
at BizHawk.Client.EmuHawk.GenericDebugger.Restart() in /_/src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs:line 110
at BizHawk.Client.EmuHawk.ToolManager.Load[T](Boolean focus, String toolPath) in /_/src/BizHawk.Client.EmuHawk/tools/ToolManager.cs:line 148
at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Host env.
- BizHawk 2.10 Windows 11 AMD
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs, especially UpdateCapabilitiesProps() line 56 and Restart() line 110. Reproduce with the Genesis Plus GX core in Master System mode using the reported ROM, then inspect the capability lookup that raises KeyNotFoundException. Done means the debugger opens without this exception for the reported setup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100