TASEmulators / TASEmulators/BizHawk
Improve error message when loading audio-only disc
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Currently discards the DiscType, only writing game.System:
https://github.com/TASEmulators/BizHawk/blob/756c79fb60ae27ef6a0b22379dbb2c60e9ede7dd/src/BizHawk.Client.Common/RomLoader.cs#L301-L305
So it ends up here:
https://github.com/TASEmulators/BizHawk/blob/756c79fb60ae27ef6a0b22379dbb2c60e9ede7dd/src/BizHawk.Client.Common/RomLoader.cs#L412
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/BizHawk.Client.Common/RomLoader.cs around lines 301-305 and 412, tracing how the audio-only disc error is assembled. Preserve the relevant DiscType in the reported message rather than only writing game.System, then verify that loading an audio-only disc produces the more informative error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100