TASEmulators / TASEmulators/BizHawk

FFI enums use implicit values

Open
#4,110 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Meta re: Waterbox
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Setting explicit values should be required in general, at least for enums used in wbox/native interop.
edit: This is Analyzer rule RCS1161. Also CA1008 for missing zero members, but wait for #4327.


Also "unplugged" / no peripheral is missing. Added in https://github.com/TASEmulators/BizHawk/commit/c5807662b607f1c9ccf7c41f27061d7b8026cd3b.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating enums used in wbox/native interop and reviewing Analyzer rule RCS1161; the issue asks for explicit enum values generally, while CA1008 and missing zero members should wait for #4327. Done means the applicable enums no longer rely on implicit values.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.