TASEmulators / TASEmulators/BizHawk
Paths config doesn't validate on close
Open
Nobody has claimed this yet.
App: EmuHawk
Request: Feature/Enhancement
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Should maybe validate at the top of this loop:
https://github.com/TASEmulators/BizHawk/blob/f28fa497955e332dca0fdae57c08c98ed10b01b3/src/BizHawk.Client.EmuHawk/config/PathConfig.cs#L218-L222
Initially reported by @Spikestuff on Discord.
see also #1574
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/BizHawk.Client.EmuHawk/config/PathConfig.cs at lines 218–222 and inspect the loop involved when the paths configuration is closed. Review issue #1574 for related context. The change is done when invalid path configuration is validated at the appropriate point before close, with the resulting behavior confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100