TASEmulators / TASEmulators/BizHawk
Maintain aspect ratio is a little longer on NES and SNES
Open
Nobody has claimed this yet.
App: EmuHawk
Repro: Affects 2.10 dev
Waiting on dev consensus
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
On NES and SNES emulation, enable Maintain aspect ratio follows 8:7 PAR, that would stretch horizontal pixel to perfect 2048 (256x8), but current BizHawk stretched it to 2051 instead, a little longer than 8:7 PAR expected size.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the NES and SNES display with Maintain aspect ratio enabled and compare the current width with the expected 8:7 PAR result. Trace the aspect-ratio calculation from the emulator display path; done when the horizontal width is 2048 rather than 2051 for the stated 256x8 case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100