TASEmulators / TASEmulators/BizHawk
[F.Rq.] Allow saving inputs while movie is in Finished mode
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Continuation of #4032 but requesting new behavior not present in any BizHawk version.
Specifically, when in Finished state, savestates should include the movie input log and inputs after up until the point of the savestate and there should probably be a way to movie and post-movie inputs as a new movie.
As far as I can tell, the current rationale for not doing this is distinguishing between savestates made before and after a movie has ended. But marking a savestate and inputs as post movie could be done without strictly throwing away inputs after a movie has ended.
Note: this is not to say necessarily we should deviate from https://tasvideos.org/LawsOfTAS/OnSavestates . There are ways to make Finished state more flexible and less of a black hole without compromising movie reliability and user safety. For savestate loading for example there could be a custom dialog when loading a savestate with inputs past the end of a movie or custom load options in the menus.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; begin by reviewing the existing Finished-state savestate and movie-input handling, along with continuation #4032. Done requires an agreed design for preserving movie and post-movie inputs, saving them, and loading or continuing them without compromising movie reliability or user safety.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100