TASEmulators / TASEmulators/BizHawk
[🐧] NES PPU Viewer's "zoom box" shouldn't be anti-aliased
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
This guy:
https://github.com/TASEmulators/BizHawk/blob/ebe3cad66c6989a7e29b9ee77ca7e426707319a2/src/BizHawk.Client.EmuHawk/tools/NES/NESPPU.Designer.cs#L726
PictureBox doesn't accept an InterpolationMode though. This SO answer suggests subclassing it and overriding OnPaint to mutate the Graphics before calling the base method. Don't forget to set PixelOffsetMode = Half too if you go ahead with this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/BizHawk.Client.EmuHawk/tools/NES/NESPPU.Designer.cs at line 726 and inspect how the zoom box PictureBox is configured. Follow the linked subclassing approach, including the suggested graphics settings, then verify that the NES PPU Viewer's zoom box displays without anti-aliasing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100