TASEmulators / TASEmulators/BizHawk

C64 disc (tape) switching leads to NRE

Open
#3,683 2 comments 0 reactions 1 assignee View on GitHub

@SaxxonPike is already working on this.

Since Jan 4, 2025.

App: EmuHawk Core: C64Hawk Repro: Patch pending
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

System.NullReferenceException: Object reference not set to an instance of an object.
   at BizHawk.Emulation.Cores.Computers.Commodore64.C64.SetDisk(Int32 discNum)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Lead suspect:
https://github.com/TASEmulators/BizHawk/blob/4ee7e4cad7129d4e8b2ef7817079ae2c1b99052c/src/BizHawk.Emulation.Cores/Computers/Commodore64/C64.cs#L213

Initially reported by jmwtac on Discord.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.